-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to draft-04 #172
Merged
kixelated
merged 14 commits into
kixelated:main
from
englishm:me/draft-ietf-moq-transport-04
Aug 16, 2024
Merged
Update to draft-04 #172
kixelated
merged 14 commits into
kixelated:main
from
englishm:me/draft-ietf-moq-transport-04
Aug 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
englishm
force-pushed
the
me/draft-ietf-moq-transport-04
branch
2 times, most recently
from
June 18, 2024 20:48
86d316e
to
42d57dd
Compare
englishm
force-pushed
the
me/draft-ietf-moq-transport-04
branch
4 times, most recently
from
June 29, 2024 06:47
f790275
to
90ba70c
Compare
englishm
force-pushed
the
me/draft-ietf-moq-transport-04
branch
from
July 25, 2024 06:53
d456610
to
9d6186e
Compare
kixelated
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotta update moq-js at least to add ObjectStatus before we can merge.
Yep, this is just blocked on kixelated/moq-js#107 and a minor rebase/cleanup to deal with version bumps that landed on main since I last touched this. |
englishm
force-pushed
the
me/draft-ietf-moq-transport-04
branch
from
August 6, 2024 05:39
66f0f81
to
74fe3e7
Compare
Not trying for any backwards compatibility here, will just roll forward to the latest draft.
Serialization/Deserialization for this new message type in moq-transport https://www.ietf.org/archive/id/draft-ietf-moq-transport-04.html#message-track-status-req Introduced in moq-wg/moq-transport#425 Note: Does not include any handling for this message type yet
Serialization/Deserialization for this new message type in moq-transport https://www.ietf.org/archive/id/draft-ietf-moq-transport-04.html#section-6.17 Introduced in moq-wg/moq-transport#425 Note: Does not include any handling for this message type yet, nor any validation of status codes
We don't _do_ anything with this information yet, but now we can at least parse it.
Set up publisher sessions to respond to track status requests
Parsing for this mesage type, but not handling (yet) Uses code from moq-wg/moq-transport#457 since it was missed in draft-04.
cargo semver-checks flagged moq-transport, but also bump binaries for wire image compatibility
englishm
force-pushed
the
me/draft-ietf-moq-transport-04
branch
from
August 9, 2024 05:21
b51425e
to
f8a4ecb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update moq-rs to draft-04
Checklist (PRs to spec between -03 and -04 tags):
405 ContentExists alignment (already matches existing implementation)
Changes that impact the Subscribe message wire format:
Object Status
Track Status
435 SUBSCRIBE_UPDATE
For a few things here, implementations are only partial (full handling isn't always implemented, and not every new feature is exposed to library consumers), but this should cover at least all of the wire image changes so that basic interop can be achieved.